Fix phsp scoring outside the geometry on entry #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where particles were scored in the phase-space even though they had left the overall geometry. This was occurring even when the particles were only meant to be scored on entry, if the region of the phase-space scoring geometry happened to be defined outside the actual geometry used in the simulation (like an infinite plane).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where particles were scored "on entry" in the phase-space even though they had left the overall geometry. This was occurring when the particles were only meant to be scored on entry to a particular geometry, if the region of the phase-space scoring geometry happened to be defined outside the actual geometry used in the simulation (like an infinite plane).
Note that this "fix" will prevent people from placing a scoring plane outside their defined geometry. Is that OK?
Bug was reported here:
https://www.reddit.com/r/EGSnrc/comments/1jga62g/framelike_structure_in_beamdp_xy_scatter_plot/
@blakewalters please check this!