remove all refops if a basic block is a raising block #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlee992
changed the title
hasDecrefInNode and hasAnyDecrefInNode if it's a raise blockisRaising check ahead before hasDecref check in refprune
dlee992
changed the title
isRaising check ahead before hasDecref check in refprune
|
Hi, @sklam. This is another small improvement for ref-pruning. It can enjoy your review! Thanks |
|
Hi, any comment for this PR and the related issue? cc @esc |
|
@dlee992 I suppose this ought to make |
|
Yeah, I will make up one test case for it ASAP (probably tmr). |
Actually, this one could be quite tricky to prove, and I don't have an existing reproducer/benchmark to show the performance benefits. So close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible way to
fix #1044
Notes for reviewers: