Skip to content

Replace Distributions with StatsBase #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nathanielpritchard opened this issue Jul 12, 2024 · 0 comments
Open

Replace Distributions with StatsBase #56

nathanielpritchard opened this issue Jul 12, 2024 · 0 comments
Labels
stylistic change A unifying change to all relevant features

Comments

@nathanielpritchard
Copy link
Contributor

When sampling from a distribution it seems that the sample! from StatsBase is a more efficient method to use as opposed to the sampling functions based on the Distributions package. This requires us to replace instances of sampling with the sample function.

This requires:

  1. Remove Distributions from Project.toml and RLinearAlgebra.jl
  2. Add StatsBase to Project.toml and import StatsBase: sample!
  3. Replace any sampling procedures with the sample function.
@nathanielpritchard nathanielpritchard added the stylistic change A unifying change to all relevant features label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stylistic change A unifying change to all relevant features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanielpritchard