Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] connector_extension: use_data and importer improved #354

Merged

Conversation

KNVx
Copy link
Contributor

@KNVx KNVx commented Jan 4, 2024

No description provided.

@KNVx KNVx requested a review from eantones January 4, 2024 15:53
@KNVx KNVx added the to review label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (d77e8af) 45.02% compared to head (0220dfc) 44.98%.

Files Patch % Lines
connector_extension/components/importer.py 10.00% 9 Missing ⚠️
connector_extension/components/adapter.py 0.00% 4 Missing ⚠️
connector_extension/models/binding/binding.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             14.0     #354      +/-   ##
==========================================
- Coverage   45.02%   44.98%   -0.05%     
==========================================
  Files         747      747              
  Lines       12972    12972              
  Branches     2837     2836       -1     
==========================================
- Hits         5841     5835       -6     
- Misses       7001     7005       +4     
- Partials      130      132       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eantones eantones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes as #353 (review)

@KNVx KNVx force-pushed the 14.0-imp-connector_extension-use_data_and_importer_improved branch from 5bafadd to 0220dfc Compare January 9, 2024 07:31
@KNVx KNVx requested a review from eantones January 9, 2024 07:37
Copy link
Member

@eantones eantones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Good job!

@eantones eantones merged commit b26cdfb into 14.0 Jan 9, 2024
4 of 6 checks passed
@eantones eantones deleted the 14.0-imp-connector_extension-use_data_and_importer_improved branch January 9, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants