[16.0][MIG] connector_ertransit #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #356 +/- ##
==========================================
+ Coverage 28.95% 29.09% +0.14%
==========================================
Files 44 50 +6
Lines 1568 1739 +171
Branches 360 395 +35
==========================================
+ Hits 454 506 +52
- Misses 1113 1232 +119
Partials 1 1 ☔ View full report in Codecov by Sentry. |
eantones
requested changes
Jan 9, 2024
| if not er.login(): | ||
| raise exceptions.ValidationError("Error on logging in") |
There was a problem hiding this comment.
Use just ValidationError("Error on logging in") without exceptions
| @@ -25,37 +24,43 @@ def _select_state(self): | |||
| ("production", "In Production"), | |||
| if not er.login(): | ||
| raise exceptions.ValidationError("Error on logging in") | ||
|
|
||
| raise exceptions.ValidationError(_("Error on logging in")) |
| if not er.logout(): | ||
| raise exceptions.ValidationError("Error on logging out") |
| if not er.logout(): | ||
| raise exceptions.ValidationError("Error on logging out") | ||
|
|
||
| raise exceptions.ValidationError(_("Error on logging out")) |
| @@ -147,14 +144,16 @@ def _update_javax_faces_viewstate(self, res): | |||
| for t in tag_javax: | |||
| if "value" not in t.attrib: | |||
| raise Exception( | |||
| @@ -147,14 +144,16 @@ def _update_javax_faces_viewstate(self, res): | |||
| for t in tag_javax: | |||
| if "value" not in t.attrib: | |||
| raise Exception( | |||
| "Unexpected, the javax.faces.ViewState element if found must have value attribute" | |||
| "Unexpected, the javax.faces.ViewState element " | |||
| "if found must have value attribute" | |||
| ) | |||
| if not self.javax_face_viewstate: | |||
| self.javax_face_viewstate = t.attrib["value"] | |||
| else: | |||
| if self.javax_face_viewstate != t.attrib["value"]: | |||
| raise Exception( | |||
KNVx
force-pushed
the
16.0-mig-connector_ertransit
branch
from
15006ea to
a8fbefc
Compare
KNVx
force-pushed
the
16.0-mig-connector_ertransit
branch
from
a8fbefc to
31e503a
Compare
… additonally to a comma separator
eantones
force-pushed
the
16.0-mig-connector_ertransit
branch
from
31e503a to
70f0344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.