[T4A2][T1-04]Dao Han #114
Open
[T4A2][T1-04]Dao Han #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import seedu.addressbook.data.person.Person; | ||
|
|
||
| /** Association class to support the following functionality: | ||
| * When the AddressBook program exits, it should print out a list of all the tags added/deleted during that session. |
There was a problem hiding this comment.
A more precise description is Represents an adding or removing a Tag to/from a Person.
| */ | ||
|
|
||
| public class Tagging { | ||
| private ArrayList<String> allTheTags = new ArrayList<>(); |
There was a problem hiding this comment.
Based on the class diagram given in the exercise, the list of Tagging objects should not be in this class. If it was in this class, the diagram would be like this:
| if (command == ADD_COMMAND) { | ||
| allTheTags.add("+ " + person.getName().toString() + " " + tag.toString()); | ||
| } | ||
| else if (command == DELETE_COMMAND) { |
| } | ||
| } | ||
|
|
||
| // To print out a list of all the tags added/deleted during the session, when the AddressBook program exits. |
| private final String DELETE_COMMAND = "remove"; | ||
|
|
||
| // Record tags added/deleted during that session. | ||
| public void trackTagging(String command, Person person, Tag tag) { |
There was a problem hiding this comment.
So Record or Track ? Be consistent.
|
@DaoHanLim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks all add/delete tag functions.