Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T4A2][T1-04]Dao Han #114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/seedu/addressbook/data/tag/Tagging.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
package seedu.addressbook.data.tag;

import java.util.ArrayList;

import seedu.addressbook.data.person.Person;

/** Association class to support the following functionality:
* When the AddressBook program exits, it should print out a list of all the tags added/deleted during that session.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more precise description is Represents an adding or removing a Tag to/from a Person.

*/

public class Tagging {
private ArrayList<String> allTheTags = new ArrayList<>();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the class diagram given in the exercise, the list of Tagging objects should not be in this class. If it was in this class, the diagram would be like this:
image

private final String ADD_COMMAND = "add";
private final String DELETE_COMMAND = "remove";

// Record tags added/deleted during that session.
public void trackTagging(String command, Person person, Tag tag) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Record or Track ? Be consistent.

if (command == ADD_COMMAND) {
allTheTags.add("+ " + person.getName().toString() + " " + tag.toString());
}
else if (command == DELETE_COMMAND) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coding standard violation?

allTheTags.add("- " + person.getName().toString() + " " + tag.toString());
}
}

// To print out a list of all the tags added/deleted during the session, when the AddressBook program exits.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prints not To print..

public String getAllTags(){
StringBuilder allActions = new StringBuilder();
for(String tag: allTheTags){
allActions.append(tag + "\n");
}
return allActions.toString();
}

}