Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T5A1][T01-T4] Tay Chi Shien #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chishien
Copy link

@chishien chishien commented Jul 5, 2017

No description provided.

storage.save(addressBook);
if (command.isMutating()) {
storage.save(addressBook);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior of the code has been changed. Ensure the header comment and the tests have been updated.

@@ -66,5 +66,10 @@ public CommandResult execute() {
return new CommandResult(MESSAGE_DUPLICATE_PERSON);
}
}

@Override
public boolean isMutating() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find the abstract method.

@jeffryhartanto
Copy link

@chishien
Some comments added. Please close the PR after reading comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants