Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W11][W12-1] V1.3 #41

Open
wants to merge 707 commits into
base: master
Choose a base branch
from

Conversation

linnnruoo
Copy link

No description provided.

@linnnruoo
Copy link
Author

@jitwei98 how to add the tag again?

@nus-se-pr-bot
Copy link

Hi @linnnruoo, your pull request title is invalid.

For PR sent to satisfy a learning outcome, the PR name should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-2] means Wednesday 2pm (14 hrs), Team 2).
E.g. If you are in tutorial W09 (i.e. Wednesday 9am), team 1, and is submitting a PR for LO W2.2b, the PR title would be [W2.2b][W09-1] James Yong. Note that your tutorial IDs are different from those shown in CORS/IVLE.

For team PR, the PR name should be in the format of [Team ID] Product Name (e.g. [T09-2] Contact List Pro).

Please follow the above format strictly and edit your title for reprocessing.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR.

@jitwei98
Copy link

jitwei98 commented Oct 3, 2018

The bot requested the name to be [W12-1] . I think I added the tag already.

@linnnruoo
Copy link
Author

@jitwei98 should we close this pull request and make new one?? or just edit the week in the title?

@jitwei98
Copy link

jitwei98 commented Oct 9, 2018

@linnnruoo I think it's better to do a new one and leave this one here.

@okkhoy
Copy link

okkhoy commented Oct 21, 2018

@linnnruoo @jitwei98 @junweiljw @driedmelon @elstonayx

  • The original addressbook application provides a reasonably well-written code example. We hope we don't screw it up.

😂

Good job on updating the sequence diagram for export command. Would encourage every one to drop in at least one UML to explain your features.

WRT code: I noticed many header comments without a description; if they are trivial methods, better to remove the comments; if not add a description of the methods.

@linnnruoo linnnruoo changed the title [W7.9][W12-1] V1.1 [W11][W12-1] V1.3 Oct 30, 2018
@linnnruoo
Copy link
Author

linnnruoo commented Oct 30, 2018

CalendarFx KIV v10 cannot pass travis which runs on jdk9(issue 77 and PR 90).
Will explore other methods to implement the calendar.
Removed some of the GUI tests that always screw our PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants