-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W11][W12-1] V1.3 #41
base: master
Are you sure you want to change the base?
[W11][W12-1] V1.3 #41
Conversation
@jitwei98 how to add the tag again? |
Hi @linnnruoo, your pull request title is invalid. For PR sent to satisfy a learning outcome, the PR name should be in the format of For team PR, the PR name should be in the format of Please follow the above format strictly and edit your title for reprocessing. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR. |
The bot requested the name to be [W12-1] . I think I added the tag already. |
@jitwei98 should we close this pull request and make new one?? or just edit the week in the title? |
@linnnruoo I think it's better to do a new one and leave this one here. |
@linnnruoo @jitwei98 @junweiljw @driedmelon @elstonayx
😂 Good job on updating the sequence diagram for export command. Would encourage every one to drop in at least one UML to explain your features. WRT code: I noticed many header comments without a description; if they are trivial methods, better to remove the comments; if not add a description of the methods. |
CalendarFx KIV v10 cannot pass travis which runs on jdk9(issue 77 and PR 90). |
Schedule command
removed TODO tasks
Modify feature list Modify Libraries used
FileUtilTest.java: Write test for isValidXmlFilename()
# Conflicts: # docs/UserGuide.adoc
PPP + ui diagram
… jitwei98/docs
PPP driedmelon
update ppp and tags on userguide
… jitwei98/docs
Minor modifications
No description provided.