[T09-3] V1.1 #67
[T09-3] V1.1 #67
Conversation
|
Hi @HyukieJun, your pull request title is invalid. For PR sent to satisfy a learning outcome, the PR name should be in the format of For team PR, the PR name should be in the format of Please follow the above format strictly and edit your title for reprocessing. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR. |
There was a problem hiding this comment.
V1.1:
- Please update the ReadMe with your project details.
- @Za-yn Please upload a closer photo of you to identify you easily
V1.2: Developer doc
- One member hasn't updated the 'inventory' feature yet
- When updating the doc parallel, try to be consistent with the level of information you provide about a feature/subtopics among the team members to increase the readability of the document as well to be more professional
- None of the design section has been updated. Please note that one team member has to contribute at least one UML diagram to the design section
- Moreover, make sure that all the retained information/images of ABL4 are updated according to the design of your project
docs/DeveloperGuide.adoc
Outdated
| @@ -298,6 +303,14 @@ The following activity diagram summarizes what happens when a user executes a ne | |||
|
|
|||
| image::UndoRedoActivityDiagram.png[width="650"] | |||
|
|
|||
| Step 7. The user executes many `add`, `delete`, and `clear` commands over a couple of hours, but decides at the end of the day that he does not want all the changes. He decides to undo all the changes by executing the `undoAll` command. The 'undoAll' command will call 'Model#undoAllAddressBook(), which will shift the 'currentStatePointer' to the start of the `addressBookStateList`, pointing it to the original address book state, and restores the address book to that state. | |||
There was a problem hiding this comment.
Good that you have updated the illustration of commands with the new commands
docs/DeveloperGuide.adoc
Outdated
| === Events | ||
|
|
||
| We create an Events package in modle, to combine the event element such as name and venue into an event list. In the Commands package, we create an package named EventCommand, which the commands are stored in. We have totally four commands: | ||
| *`addEventsCommand` -- Add a new event to the event list. |
There was a problem hiding this comment.
You do not need to list down the commands here. It must be listed in the user guide. Perhaps, you can provide a sequence of possible actions for this feature similar to undo/redo feature
docs/DeveloperGuide.adoc
Outdated
| *`deleteEvent` -- Delete the a certain event. | ||
|
|
||
| The users need to type openCalendar, and then type the corresponding command. | ||
| Inside the parser package, we have the corresponding CommandParser. For example, addEventParser. What does the parser do is it divides the information typed in into several parts, which are name, venue, date, and description. |
There was a problem hiding this comment.
This level of implementation detail is not necessary unless the responsibility of the parser is not trivial
docs/DeveloperGuide.adoc
Outdated
| Inside the parser package, we have the corresponding CommandParser. For example, addEventParser. What does the parser do is it divides the information typed in into several parts, which are name, venue, date, and description. | ||
| After that, the AddEventCommand will store the parts into an EventList. | ||
|
|
||
| === Add/Remove Ledger feature |
There was a problem hiding this comment.
Good that one team member is consistent with the level of information to provide for a feature.
| @@ -839,6 +907,18 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un | |||
|
|
|||
| |`* * *` |user |find a person by name |locate details of persons without having to go through the entire list | |||
|
|
|||
| |`* * *` |user |add an event | | |||
There was a problem hiding this comment.
As I mentioned in the 'Member' section, you do not need to list down all the possible commands here. It is supposed to be available in the user guide. Perhaps, you may illustrate a sequence of actions here similar to the undo/redo section.
| |`* * *` |user |delete an item | remove item entries that I no longer need | ||
|
|
||
| |`* * *` |user |find an item by name |locate details on items without having to go through the entire list | ||
|
|
||
| |`* *` |user |hide <<private-contact-detail,private contact details>> by default |minimize chance of someone else seeing them by accident | ||
|
|
FindbyMajor function added
Test cases for member class updated
Test Cases updated
…into DarylBranch # Conflicts: # src/main/java/seedu/address/logic/Logic.java # src/main/java/seedu/address/logic/LogicManager.java # src/main/java/seedu/address/logic/commands/MemberCommand/AddMemberCommand.java # src/main/java/seedu/address/logic/commands/MemberCommand/EditMemberCommand.java # src/main/java/seedu/address/logic/parser/AddressBookParser.java # src/main/java/seedu/address/model/AddressBook.java # src/main/java/seedu/address/model/Model.java # src/main/java/seedu/address/model/ReadOnlyAddressBook.java # src/test/java/seedu/address/logic/commands/AddMemberCommandTest.java # src/test/java/seedu/address/model/AddressBookTest.java
UI for ItemList, reposense config, README.adoc changes
PPP changes + Syntax fix for testcases
Final travis
d
checkstyle
delete all failing tests :(
UDGD and PPP update
change
ug newline
No description provided.