fixup! only call setup function in BeforeClusterCreate

Author: dkoshkin

pkg/handlers/generic/lifecycle/registry/cncfdistribution/handler.go

@@ -64,6 +64,9 @@ func New(
 	}
 }
 
+// Setup ensures any pre-requisites for the CNCF Distribution registry addon are met.
+// It is expected to be called before the cluster is created.
+// Specifically, it ensures that the CA secret for the registry is created in the cluster's namespace.
 func (n *CNCFDistribution) Setup(
 	ctx context.Context,
 	_ v1alpha1.RegistryAddon,
@@ -82,6 +85,7 @@ func (n *CNCFDistribution) Setup(
 	return nil
 }
 
+// Apply applies the CNCF Distribution registry addon to the cluster.
 func (n *CNCFDistribution) Apply(
 	ctx context.Context,
 	_ v1alpha1.RegistryAddon,

pkg/handlers/generic/lifecycle/registry/handler.go

@@ -92,7 +92,6 @@ func (r *RegistryHandler) BeforeClusterUpgrade(
 	resp *runtimehooksv1.BeforeClusterUpgradeResponse,
 ) {
 	commonResponse := &runtimehooksv1.CommonResponse{}
-	r.setup(ctx, &req.Cluster, commonResponse)
 	r.apply(ctx, &req.Cluster, commonResponse)
 	resp.Status = commonResponse.GetStatus()
 	resp.Message = commonResponse.GetMessage()