fix: set defaults for AWS CP and Worker instanceType #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supershal
changed the title
dkoshkin
approved these changes
Apr 11, 2024
dkoshkin
reviewed
Apr 11, 2024
supershal
force-pushed
the
shalin/ncn-default_instance_type
branch
from
5b417d0 to
bce383c
Compare
jimmidyson
approved these changes
Apr 15, 2024
Merged
jimmidyson
pushed a commit
that referenced
this pull request
Apr 15, 2024
Moved: d2iq-labs#54 **What problem does this PR solve?:** This is a stacked PR: #504 sets defaults for aws instance profiles CP: `control-plane.cluster-api-provider-aws.sigs.k8s.io` and Workers: `nodes.cluster-api-provider-aws.sigs.k8s.io` removes instanceProfile field in AWSMachineTemplates **Which issue(s) this PR fixes:** Fixes # **How Has This Been Tested?:** Tested manually be creating AWS cluster. Created AWS cluster without adding instanceProfile variable, CAREN patched AWSMachineTemplate with default instanceProfile. **Special notes for your reviewer:** Looking into ways to unit test the defaults.
jimmidyson
pushed a commit
that referenced
this pull request
Apr 15, 2024
🤖 I have created a release *beep* *boop* --- ## 0.7.0 (2024-04-15) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Sync up from d2iq-labs fork by @jimmidyson in #489 * feat: set default instance profile for AWS CP and worker nodes by @supershal in #506 ### Fixes 🔧 * fix: set defaults for AWS CP and Worker instanceType by @supershal in #504 ### Other Changes * build: Remove unused tool crane by @jimmidyson in #459 * ci: Add govulncheck check by @jimmidyson in #461 * ci: Remove auto-approve PR steps by @jimmidyson in #462 * build: Tidy up examples sync script by @jimmidyson in #458 * test: Remove redundant test case from httpproxy handler by @dlipovetsky in #463 * ci: Fix pages workflow concurrency by @jimmidyson in #493 * refactor: Replace direct usage of CAAPH API with vendored types by @jimmidyson in #492 * refactor: Update module paths to use nutanix-cloud-native GH org by @jimmidyson in #494 * build: Remove unused capbk and capd hack modules by @jimmidyson in #496 * docs: add pull request template for the repository by @supershal in #502 * docs: Add file extension to containerd-metrics doc by @dlipovetsky in #503 * build: set dockerhub credentials for Nutanix examples by @dkoshkin in #501 **Full Changelog**: v0.6.0...v0.7.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved d2iq-labs#51
Addressed the pending review comments
What problem does this PR solve?:
update existing unit tests to use default schema
NOTE
Once this PR is finalized, I will create follow up PR to set instance profile and some other changes in the API types that would ensure that it creates variable schema from the object instead of creating new one.
Which issue(s) this PR fixes:
Fixes # #485
How Has This Been Tested?:
Tried to test locally using make e2e-test E2E_LABEL='provider:AWS && cni:Cilium' but local environment timed outs during initializations. Looking into fixing local environment (colima +docker +kind on mac)
Tested manually be creating AWS cluster.
aws-quick-start cluster class has following
and workers
Created AWS cluster without adding instanceType variable, CAREN patched AWSMachineTemplate with default instanceType.
** Special notes for your reviewer:**
The approach taken in this PR will be used as guide to set default for other variables.