feat: Add dynamic addon handler application via controller #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This commit enables out of upgrade flow application of lifecycle hooks. This enables dynamic updates of cluster variables that will result in application of the lifecycle hook without requiring an upgarde to be in progress.
jimmidyson
force-pushed
the
jimmi/addon-controller-apply
branch
from
eaff387 to
df9e87e
Compare
|
The design doc has diverged from this implementation, can we close this PR (but keep the branch around)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables out of upgrade flow application of lifecycle hooks. This
enables dynamic updates of cluster variables that will result in application of
the lifecycle hook without requiring an upgrade to be in progress.