Fix the kubebuilder enum (#42)

* Fix the kubebuilder enum

Use semi-colon to separate out enum values

* Update Github action

Run linting on kubebuilder annotations.

Author: thunderboltsid

.github/workflows/build-lint-test.yml

@@ -34,6 +34,9 @@ jobs:
     - name: Check YAML linting
       run: make lint-yaml
 
+    - name: Check Kubebuilder Annotation linting
+        run: make lint-kubebuilder
+
     - name: Run tests
       run: make test
 

CHANGELOG.md

@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- Bugfix: Fix the kubebuilder enum annotations for NutanixTrustBundleKind
 
 ## [0.3.1] - 2022-11-03
 ### Added

Makefile

@@ -37,6 +37,9 @@ endef
 TOOLS_BIN_DIR := hack/tools/bin
 CONTROLLER_GEN_BIN := controller-gen
 CONTROLLER_GEN := $(TOOLS_BIN_DIR)/$(CONTROLLER_GEN_BIN)
+# CRD_OPTIONS define options to add to the CONTROLLER_GEN
+CRD_OPTIONS ?= "crd:crdVersions=v1"
+
 
 $(TOOLS_BIN_DIR):
 	mkdir -p $(TOOLS_BIN_DIR)
@@ -72,8 +75,7 @@ ifeq ($(EXPORT_RESULT), true)
 endif
 
 ## Lint:
-lint: lint-go lint-yaml ## Run all available linters
-
+lint: lint-go lint-yaml lint-kubebuilder ## Run all available linters
 
 lint-go: ## Use golintci-lint on your project
 	$(eval OUTPUT_OPTIONS = $(shell [ "${EXPORT_RESULT}" == "true" ] && echo "--out-format checkstyle ./... | tee /dev/tty > checkstyle-report.xml" || echo "" ))
@@ -86,6 +88,10 @@ ifeq ($(EXPORT_RESULT), true)
 endif
 	docker run --rm -it -v $(shell pwd):/data cytopia/yamllint -d relaxed -f parsable $(shell git ls-files '*.yml' '*.yaml') $(OUTPUT_OPTIONS)
 
+.PHONY: lint-kubebuilder
+lint-kubebuilder: $(CONTROLLER_GEN) ## Lint Kubebuilder annotations by generating objects and checking if it is successful
+	$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=.
+
 ## Help:
 help: ## Show this help.
 	@echo ''

environment/credentials/types.go

@@ -89,7 +89,7 @@ const (
 // +kubebuilder:object:generate=true
 type NutanixTrustBundleReference struct {
 	// Kind of the Nutanix trust bundle
-	// +kubebuilder:validation:Enum=String,Secret,ConfigMap
+	// +kubebuilder:validation:Enum=String;ConfigMap
 	Kind NutanixTrustBundleKind `json:"kind"`
 	// Data of the trust bundle if Kind is String.
 	// +optional