* Improved automatic opening of Devtools in browser (#415)

* Made function 'start_browser' in module 'devtools' public, so that the user may call the function on their own

Author: obemu

lua/flutter-tools/dev_tools.lua

@@ -41,18 +41,26 @@ local function try_get_profiler_url_chrome(data)
   return data:match("(ws%:%/%/127%.0%.0%.1%:%d+/.+/ws)$")
 end
 
-local function start_browser()
+function M.start_browser()
   local auto_open_browser = config.dev_tools.auto_open_browser
   if not auto_open_browser then return end
+
   local url = M.get_profiler_url()
+  if not url then return end
+
   local open_command = utils.open_command()
   if not open_command then
     return ui.notify(
       "Sorry your Operating System is not supported, please raise an issue",
       ui.ERROR
     )
   end
-  if url and open_command then vim.fn.jobstart({ open_command, url }, { detach = true }) end
+
+  Job:new({
+    command = open_command,
+    args = { url },
+    detached = true
+  }):start()
 end
 
 function M.handle_log(data)
@@ -84,7 +92,7 @@ function M.register_profiler_url(url)
 end
 
 function M.handle_devtools_available()
-  start_browser()
+  M.start_browser()
   ui.notify("Detected devtools url, execute FlutterCopyProfilerUrl to copy it")
 end
 
@@ -103,16 +111,21 @@ end
 ---@param data string
 ---@param _ Job
 local function handle_start(_, data, _)
-  if #data > 0 then
-    local json = fn.json_decode(data)
-    if json and json.params then
-      devtools_pid = json.params.pid
-      devtools_url = string.format("http://%s:%s", json.params.host, json.params.port)
-      start_browser()
-      local msg = string.format("Serving DevTools at %s", devtools_url)
-      ui.notify(msg, ui.INFO, { timeout = 20000 })
-    end
-  end
+  if #data <= 0 then return end
+
+  local json = fn.json_decode(data)
+  if not json or not json.params then return end
+
+  devtools_pid = json.params.pid
+  if not json.params.host or not json.params.port then return end
+
+  devtools_url = string.format("http://%s:%s", json.params.host, json.params.port)
+  M.start_browser()
+  ui.notify(
+    string.format("Serving DevTools at %s", devtools_url),
+    ui.INFO,
+    { timeout = 10000 }
+  )
 end
 
 ---Handler errors whilst opening dev tools