fix: don't attach lsp to buffer with empty path #332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, on one of my projects, LSP tries to attach to a buffer with an empty path. Dart language server recognizes this as
/
root directory and starts to analyze the whole file system and eventually just freezes.https://github.com/akinsho/flutter-tools.nvim/blob/271eec9edb0f1a2bf30ad449ec3b4eeb2c88af05/lua/flutter-tools/lsp/init.lua#L198
After adding some print statements for debugging, I found out it happens every time the floating window with diagnostic is open. However, there is no such buffer when I check the buffer list with
:ls
, so I'm not sure what exactly causes this. Anyway, check for an empty string is a nice addition tois_valid_path
function.