Inline-link target proposal #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
commented
Jan 15, 2022
Comment on lines
+182
to
+194
| $.inline_link_target_open, | ||
| $.inline_link_target_close, |
There was a problem hiding this comment.
This is slightly inconsistent right now:
- attached markup is generally treated like this
- BUT: link descriptions and texts are not treated the same way...
- this is somewhat inbetween. How shall we unify this?
There was a problem hiding this comment.
This will be unified when specifying the formal spec in #29. Generally speaking, link objects {}, [], and <> form there own category and should not be treated like attached modifiers.
mrossinek
force-pushed
the
inline-link-targets
branch
from
5548848 to
4e71625
Compare
mrossinek
force-pushed
the
inline-link-targets
branch
from
0e0a95c to
f69a195
Compare
|
Superseded by #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the inline-link target syntax as proposed here:
https://github.com/nvim-neorg/dev-notes/blob/main/syntax/inline-link-targets/index.norg