Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new vim.ui.input instead of vim.fn.input #26

Closed
IndianBoy42 opened this issue Nov 10, 2021 · 1 comment · Fixed by #27
Closed

Use new vim.ui.input instead of vim.fn.input #26

IndianBoy42 opened this issue Nov 10, 2021 · 1 comment · Fixed by #27
Labels
enhancement New feature or request

Comments

@IndianBoy42
Copy link
Contributor

Is your feature request related to a problem? Please describe.
vim.ui.input is a newly merged lua function for taking user text input. It is used by default in vim.lsp.buf.rename(). The advantage is it is 'overridable' with a custom lua function.

Describe the solution you'd like
Change this line to use vim.ui.input. The API is not exactly the same, you must provide an on_confirm callback to receive the user input.
@IndianBoy42 IndianBoy42 added the enhancement New feature or request label Nov 10, 2021
@stsewd
Copy link
Member

stsewd commented Nov 16, 2021

This should be done like nvim-treesitter/nvim-treesitter#1892, so it doesn't break on old versions of neovim.

@IndianBoy42 IndianBoy42 mentioned this issue Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vim.ui.input to vim.fn.input IndianBoy42/nvim-treesitter-refactor
2 participants
@stsewd @IndianBoy42