feat(c): add text objects for statement conditions #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have committed to this project so you might have commit rights ? |
|
I don't unfortunately, but I will try and bump this. Are you able to review @kiyoon? |
|
Tests are failing. (Cpp inherits from C, so the failure is meaningful.) |
|
Damn, thanks I'll check that out. And thanks for the invite! :D |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
I think this PR is valid now but tests are failing due to some vlang issue. I will try to get a quick fix for that then rebase. |
|
Thanks for your work. Btw I'm currently doing a short military service so I won't be able to review this month |
|
@kiyoon stay safe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
@conditional.innerto include not just the body of e.g. an if statement, but also the condition itself (and conditions for while loops, do while, etc.)