Skip to content

Commit 1cd5616

Browse files
Merge pull request #362 from nvisionative/develop
Merge `develop` into `main` for `3.1.0` release
2 parents feca6ae + 6fef6cf commit 1cd5616

17 files changed

+85
-188
lines changed

docs/Commands.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ This sets your node instance to watch all changes of images, JS and SCSS in the
2626

2727
**Note:** _This command will take over your node instance (in Command Prompt, PowerShell, Git Bash, VS Code Terminal, etc.). Therefore, you may want to start a new instance if you need to run other commands at the same time._
2828

29-
### gulp package
29+
### gulp packageTheme
3030
This command builds and packages your custom theme into a DNN theme installation package (ZIP file). It will place the ZIP file in the `./build/` folder using the following naming convention: `[project]_[version]_install.zip`
3131

3232

@@ -72,4 +72,4 @@ ZIPs contents of `./menus/` folder, `./partials/` folder, and all ASCX, XML, HTM
7272
ZIPs all subset ZIP files and other pertinent project files into theme package installation file using the following naming convention: `[project]_[version]_install.zip`
7373

7474
### gulp cleantemp
75-
Deletes all temporary ZIP and project files from `./temp/` folder used in package tasks.
75+
Deletes all temporary ZIP and project files from `./temp/` folder used in package tasks.

gulpfile.js

+18-3
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,18 @@ const paths = {
3232
dest: './dist/fonts/'
3333
},
3434
faFonts: {
35-
src: './node_modules/@fortawesome/fontawesome-free/webfonts/*',
35+
src: [
36+
'./node_modules/@fortawesome/fontawesome-free/webfonts/fa-brands-400.*',
37+
'./node_modules/@fortawesome/fontawesome-free/webfonts/fa-solid-900.*'
38+
],
3639
dest: './dist/webfonts/'
3740
},
3841
faCss: {
39-
src: './node_modules/@fortawesome/fontawesome-free/css/all.min.css',
42+
src: [
43+
'./node_modules/@fortawesome/fontawesome-free/css/brands.min.css',
44+
'./node_modules/@fortawesome/fontawesome-free/css/solid.min.css',
45+
'./node_modules/@fortawesome/fontawesome-free/css/fontawesome.min.css',
46+
],
4047
dest: './dist/css/'
4148
},
4249
normalize: {
@@ -394,7 +401,15 @@ function cleantemp() {
394401
//gulp serve
395402
function serve() {
396403
bs.init({
397-
proxy: "nvQuickTheme.loc"
404+
proxy: "nvQuickTheme.loc",
405+
rewriteRules: [
406+
{
407+
match: /w\[".*"].*/g,
408+
fn: (req, _res, match) => {
409+
return match.replace(/(http:\/\/|https:\/\/)[a-zA-Z0-9.-]+\//g, `//${req.headers.host}/`);
410+
}
411+
},
412+
],
398413
});
399414
gulp.watch(paths.images.src, images).on('change', bs.reload);
400415
gulp.watch(paths.styles.src, styles).on('change', bs.reload);

manifest.dnn

+1-7
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,10 @@
8080
</staticContent>
8181
</node>
8282
<node path="/configuration/system.webServer/staticContent" action="update" key="fileExtension" collision="ignore">
83-
<remove fileExtension=".eot" />
84-
<mimeMap fileExtension=".eot" mimeType="application/vnd.ms-fontobject" />
85-
<remove fileExtension=".otf" />
86-
<mimeMap fileExtension=".otf" mimeType="font/otf" />
8783
<remove fileExtension=".svg" />
8884
<mimeMap fileExtension=".svg" mimeType="image/svg+xml" />
89-
<remove fileExtension=".woff" />
90-
<mimeMap fileExtension=".woff" mimeType="font/x-woff" />
9185
<remove fileExtension=".woff2" />
92-
<mimeMap fileExtension=".woff2" mimeType="application/font-woff2" />
86+
<mimeMap fileExtension=".woff2" mimeType="font/woff2" />
9387
</node>
9488
</nodes>
9589
</configuration>

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
"license": "GPL-3.0",
88
"private": true,
99
"dependencies": {
10-
"@fortawesome/fontawesome-free": "^6.2.0",
10+
"@fortawesome/fontawesome-free": "^6.5.1",
1111
"bootstrap": "^5.2.2",
1212
"normalize.css": "^8.0.1"
1313
},
1414
"devDependencies": {
15-
"browser-sync": "^2.27.10",
15+
"browser-sync": "^2.29.3",
1616
"fancy-log": "^2.0.0",
1717
"gulp": "^4.0.2",
1818
"gulp-autoprefixer": "^8.0.0",

partials/_includes.ascx

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
<dnn:META ID="mobileScale" runat="server" Name="viewport" Content="width=device-width, initial-scale=1.0" />
22
<dnn:DnnCssExclude runat="server" Name="dnndefault" />
33

4-
<dnn:DnnCssInclude runat="server" FilePath="dist/css/all.min.css" Priority="100" PathNameAlias="SkinPath" />
5-
<dnn:DnnCssInclude runat="server" FilePath="dist/css/style.min.css" Priority="110" PathNameAlias="SkinPath" />
4+
<dnn:DnnCssInclude runat="server" FilePath="dist/css/fontawesome.min.css" Priority="100" PathNameAlias="SkinPath" />
5+
<dnn:DnnCssInclude runat="server" FilePath="dist/css/brands.min.css" Priority="110" PathNameAlias="SkinPath" />
6+
<dnn:DnnCssInclude runat="server" FilePath="dist/css/solid.min.css" Priority="120" PathNameAlias="SkinPath" />
7+
<dnn:DnnCssInclude runat="server" FilePath="dist/css/style.min.css" Priority="130" PathNameAlias="SkinPath" />
68

79
<dnn:DnnJsInclude runat="server" FilePath="dist/js/bootstrap.bundle.min.js" ForceProvider="DnnFormBottomProvider" Priority="100" PathNameAlias="SkinPath" />
810
<dnn:DnnJsInclude runat="server" FilePath="dist/js/custom.min.js" ForceProvider="DnnFormBottomProvider" Priority="110" PathNameAlias="SkinPath" />
@@ -15,7 +17,6 @@
1517
var fonts = new string[]
1618
{
1719
"dist/webfonts/fa-brands-400",
18-
"dist/webfonts/fa-regular-400",
1920
"dist/webfonts/fa-solid-900",
2021
"dist/fonts/OpenSans-Bold",
2122
"dist/fonts/OpenSans-BoldItalic",
@@ -31,7 +32,6 @@
3132
3233
var types = new Dictionary<string, string>();
3334
types.Add("woff2", "font/woff2");
34-
types.Add("woff", "font/woff");
3535
3636
var defaultPage = (CDefault)this.Page;
3737

src/fonts/OpenSans-Bold.woff

-68.5 KB
Binary file not shown.

src/fonts/OpenSans-BoldItalic.woff

-79.5 KB
Binary file not shown.

src/fonts/OpenSans-ExtraBold.woff

-68.2 KB
Binary file not shown.
-79.9 KB
Binary file not shown.

src/fonts/OpenSans-Italic.woff

-82.1 KB
Binary file not shown.

src/fonts/OpenSans-Light.woff

-67.7 KB
Binary file not shown.

src/fonts/OpenSans-LightItalic.woff

-82.3 KB
Binary file not shown.

src/fonts/OpenSans-Regular.woff

-65.9 KB
Binary file not shown.

src/fonts/OpenSans-SemiBold.woff

-68.2 KB
Binary file not shown.
-82.2 KB
Binary file not shown.

src/scss/components/_dnn.scss

+18-96
Original file line numberDiff line numberDiff line change
@@ -323,10 +323,10 @@ legend.error {
323323
}
324324

325325
/*
326-
* 1. Display hand cursor for clickable form elements
327-
* 2. Allow styling of clickable form elements in iOS
328-
* 3. Correct inner spacing displayed oddly in IE7 (doesn't effect IE6)
329-
*/
326+
* 1. Display hand cursor for clickable form elements
327+
* 2. Allow styling of clickable form elements in iOS
328+
* 3. Correct inner spacing displayed oddly in IE7 (doesn't effect IE6)
329+
*/
330330

331331
.dnnFormItem button,
332332
.dnnFormItem input[type="button"],
@@ -337,68 +337,23 @@ legend.error {
337337
.dnnTertiaryAction,
338338
ul.dnnAdminTabNav li a,
339339
.dnnLogin .LoginTabGroup span {
340-
display: inline-block;
341-
padding: 9px 9px;
342-
margin-bottom: 9px;
343-
cursor: pointer;
344-
min-width: 75px;
345-
*overflow: visible;
346-
border: 1px solid #c2c2c2;
347-
background: #eaeaea;
348-
border-radius: 0.25px;
349-
color: #333;
350-
font-weight: bold;
351-
text-decoration: none;
352-
text-align: center;
353-
}
354-
355-
.dnnFormItem button,
356-
.dnnFormItem input[type="button"],
357-
.dnnFormItem input[type="reset"],
358-
.dnnFormItem input[type="submit"],
359-
.dnnPrimaryAction,
360-
.dnnSecondaryAction,
361-
.dnnTertiaryAction {
362-
padding: 6px 6px;
340+
@extend .btn;
341+
margin-top: 0.5rem;
342+
margin-bottom: 0.5rem;
363343
}
364344

365345
/* Primary Action */
366346

367347
.dnnPrimaryAction,
368348
.dnnFormItem input[type="submit"],
369349
a.dnnPrimaryAction {
370-
border-color: color('dnnPrimaryAction');
371-
background: color('dnnPrimaryAction');
372-
color: #efefef;
373-
text-shadow: 0px -1px 0px #185B93;
374-
cursor: pointer;
375-
}
376-
377-
.dnnPrimaryAction:hover,
378-
.dnnFormItem input[type="submit"]:hover,
379-
a.dnnPrimaryAction:hover {
380-
border-color: #6cb6f3;
381-
background: #6cb6f3;
382-
/* Old browsers */
383-
color: #fff;
384-
}
385-
386-
.dnnPrimaryAction:active,
387-
.dnnFormItem input[type="submit"]:active,
388-
a.dnnPrimaryAction:active {
389-
border-color: color('dnnPrimaryAction');
390-
background: color('dnnPrimaryAction');
391-
color: #fff;
350+
@extend .btn-main-shade;
392351
}
393352

394353
.dnnPrimaryAction[disabled],
395354
.dnnPrimaryAction[disabled]:hover,
396355
.dnnPrimaryAction[disabled]:active {
397-
background: #ccc !important;
398-
border: none !important;
399-
box-shadow: none !important;
400-
color: #aaa !important;
401-
text-shadow: none;
356+
@extend .btn-disabled !optional;
402357
}
403358

404359
/* Secondary Action */
@@ -409,24 +364,7 @@ a.dnnPrimaryAction:active {
409364
a.dnnSecondaryAction,
410365
ul.dnnAdminTabNav li a,
411366
.dnnLogin .LoginTabGroup span {
412-
background: color('dnnSecondaryAction');
413-
/* Old browsers */
414-
border-color: color('dnnSecondaryAction');
415-
text-shadow: 0px 1px 0px #ffffff;
416-
color: #333;
417-
cursor: pointer;
418-
}
419-
420-
.dnnFormItem button:hover,
421-
.dnnFormItem input[type="button"]:hover,
422-
.dnnFormItem input[type="reset"]:hover,
423-
.dnnSecondaryAction:hover,
424-
a.dnnSecondaryAction:hover,
425-
ul.dnnAdminTabNav li a:hover,
426-
.dnnLogin .LoginTabGroup span:hover {
427-
background: whitesmoke;
428-
/* Old browsers */
429-
color: #555;
367+
@extend .btn-main-highlight;
430368
}
431369

432370
.dnnFormItem button:active,
@@ -435,8 +373,8 @@ ul.dnnAdminTabNav li a:hover,
435373
.dnnSecondaryAction:active,
436374
a.dnnSecondaryAction:active,
437375
ul.dnnAdminTabNav li a:active {
438-
border-color: color('dnnSecondaryAction');
439-
background: color('dnnSecondaryAction');
376+
border-color: color('main-accent');
377+
background: color('main-accent');
440378
}
441379

442380
/* Fix some old forge modules use .dnnPrimaryAction and .dnnSecondaryAction in wrong way */
@@ -456,34 +394,19 @@ span.dnnSecondaryAction>a.dnnSecondaryAction {
456394
/* Tertiary Action */
457395
.dnnTertiaryAction,
458396
a.dnnTertiaryAction {
459-
padding: 10px 10px;
460-
border: none;
461-
background: color('dnnTertiaryAction');
462-
color: #333;
463-
}
464-
465-
.dnnTertiaryAction:hover,
466-
a.dnnTertiaryAction:hover {
467-
background: #f2f2f2;
468-
}
469-
470-
.dnnTertiaryAction:active,
471-
a.dnnTertiaryAction:active {
472-
background: color('dnnTertiaryAction');
397+
@extend .btn-main-accent;
473398
}
474399

475400
/* Action Button behind input */
476401
.dnnFormItem input[type="text"]+a.dnnPrimaryAction,
477402
.dnnFormItem input[type="text"]+a.dnnSecondaryAction,
478403
.dnnFormItem input[type="text"]+a.dnnTerriaryAction {
479-
display: inline-block;
480-
width: auto;
481-
margin: 6px 5px 6px 5px;
404+
margin-left: 0.325rem;
482405
}
483406

484-
.dnnFormItem input[type="checkbox"]+span,
485-
.dnnFormItem input[type="radio"]+span {
486-
margin: 5px;
407+
.dnnFormItem input[type="checkbox"] + span,
408+
.dnnFormItem input[type="radio"] + span {
409+
margin: 0.325rem;
487410
}
488411

489412
/* text style for buttons and link buttons used in the portal admin pages */
@@ -497,8 +420,7 @@ a.dnnTertiaryAction:active {
497420
/* Re-set default cursor for disabled elements */
498421
.dnnFormItem button[disabled],
499422
.dnnFormItem input[disabled] {
500-
cursor: default;
501-
opacity: 0.5;
423+
@extend .btn-disabled !optional;
502424
}
503425

504426

0 commit comments

Comments
 (0)