Skip to content

Commit e13c0c7

Browse files
authored
Merge pull request #19 from nytimes/go124
Update Go to 1.24 and gcloud sdk to 513.0.0
2 parents 2a611ee + 71677ac commit e13c0c7

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
FROM golang:1.23 as golang
1+
FROM golang:1.24 as golang
22

3-
FROM gcr.io/google.com/cloudsdktool/cloud-sdk:491.0.0
3+
FROM gcr.io/google.com/cloudsdktool/cloud-sdk:513.0.0
44

55
COPY --from=golang /usr/local/go/ /usr/local/go/
66

README.md

+13
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,18 @@ following `gcloud` components:
77
- `app-engine-go`
88
- `cloud-datastore-emulator`
99

10+
# Updating Instructions
11+
12+
- Bump the major version of Go in `Dockerfile` to the latest Go version i.e.
13+
`1.24`
14+
- Bump the version of `cloud-sdk` in `Dockerfile`
15+
- Find the `latest` version [here][gcloud]
16+
- Open a Pull Request with those changes
17+
- Merge the Pull Request after review and tests pass
18+
- Tag a release using the Go version as the naming convention i.e. `1.24.0`
19+
- Verify the tag was pushed to [Docker Hub][dockerhub]
20+
1021
[actions]: https://github.com/nytimes/golang-gcloud-sdk/actions
1122
[badge]: https://github.com/nytimes/golang-gcloud-sdk/actions/workflows/build.yml/badge.svg
23+
[gcloud]: https://gcr.io/google.com/cloudsdktool/cloud-sdk
24+
[dockerhub]: https://hub.docker.com/r/nytimes/golang-gcloud-sdk

0 commit comments

Comments
 (0)