Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object typecheck to avoid unnecessary proxy method calls #6

Open
oamaok opened this issue Jul 30, 2021 · 0 comments
Open

Add object typecheck to avoid unnecessary proxy method calls #6

oamaok opened this issue Jul 30, 2021 · 0 comments
Labels
performance

Comments

@oamaok
Copy link
Owner

oamaok commented Jul 30, 2021

Also reference the obj, not the proxy. Faster access, as access to the proxy variable will always go through then handler.

kaiku/src/kaiku.ts

Line 415 in 9824297

proxy[key] = proxy[key]

@oamaok oamaok changed the title Add object typecheck to avoid unnecessary calls Add object typecheck to avoid unnecessary proxy method calls Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oamaok