Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of $kameleon_data_dir on its own #127

Closed
wants to merge 1 commit into from
Closed

Allow use of $kameleon_data_dir on its own #127

wants to merge 1 commit into from

Conversation

bleuse
Copy link

@bleuse bleuse commented Dec 5, 2022

This commit fixes the regex replacing $kameleon_data_dir to stop on whitespaces (as defined by \s) instead of blindly matching everything that follows.

This is an attempt to adress #124.

@bleuse
Allow use of $kameleon_data_dir on its own
5a286a4 
This commit fixes the regex replacing $kameleon_data_dir to stop on
whitespaces (as defined by \s) instead of blindly matching everything
that follows.
@bleuse bleuse linked an issue Dec 5, 2022 that may be closed by this pull request
Copy folder structure between context #124
Open
@bleuse bleuse requested a review from npf December 5, 2022 10:57
@bleuse
Copy link
Author

bleuse commented Jan 24, 2023

This attempt does not solve the problem.
I close this MR and will document on #124 why this is not sufficient and give some possible direction to address this point.

@bleuse bleuse closed this Jan 24, 2023
@npf
Copy link
Contributor

npf commented Feb 2, 2024 •
edited
Loading

@bleuse, any news on that question? Is a fix still required ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npf npf Awaiting requested review from npf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy folder structure between context
2 participants
@bleuse @npf