docs/node/sentry: Update config file for 23.0 #645
Conversation
✅ Deploy Preview for oasisprotocol-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| - "{{ sentry_node_grpc_public_key }}@{{ sentry_node_private_ip }}:9009" | ||
|
|
||
| # Consensus backend. | ||
| mode: client |
There was a problem hiding this comment.
There were previously two configs, one for the sentry node, and one for the "normal" node, which is connecting to the sentry. Seems that one of the configs is missing now?
There was a problem hiding this comment.
Yeah, you are right. Added both configs and re-added comments.
amela
force-pushed
the
amela/update-config-sentry-23.0
branch
from
b5f4ceb to
f3b4a30
Compare
| disable_peer_exchange: true | ||
| persistent_peers: | ||
| - {{ sentry_node_tendermint_id }}@{{ sentry_node_private_ip }}:26656 | ||
| prune: |
There was a problem hiding this comment.
Does anyone know why did we have pruning configured here for the validator? e.g. for normal validator node we don't have pruning configured in the examples. I would just remove this "prune section" from this config (i think it's ok to keep in the other (sentry) config above, it makes more sense there).
edit actually idk. if it makes sense on the sentry to keep it this low. That means if validator is disconnected for ~1 hour it won't be able to sync from the sentry? Maybe remove prunning there as well, since it's not necessary.
| consensus: | ||
| external_address: tcp://{{ external_address }}:26656 | ||
| listen_address: tcp://0.0.0.0:26656 | ||
| prune: |
There was a problem hiding this comment.
I would remove pruning here as well since it's not really necessary and we usually don't have it configured in these example configs.
amela
force-pushed
the
amela/update-config-sentry-23.0
branch
from
ecdd90c to
bbf0473
Compare
amela
force-pushed
the
amela/update-config-sentry-23.0
branch
from
bbf0473 to
6792806
Compare
Migrated with
oasis-node config migrateand updated variables. Please review.