Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Revamp manage-tokens chapters #777

Merged
merged 5 commits into from
May 8, 2024
Merged

Conversation

matevz
Copy link
Member

@matevz matevz commented Mar 28, 2024

Implements https://app.clickup.com/t/8693utwrh

PREVIEW

This PR revamps the Manage tokens chapter (and its subchapters):

  • the main chapter talks about the token and address format, token operations, consensus vs ParaTime, current wallets+ledger, 3rd party custody, the new Obtain ROSE section about CEXes/DEXes, new diagram, new OasisScan screenshots. Didn't want to operate with concrete CEX and DEX names, this should go onto the website
  • the deposit&withdrawal chapter was removed and merged into particular wallet implementation (web, ext, cli)
  • all Oasis wallets have standardized: create account, import account, transfer, stake, ParaTimes sections; tab widgets are now preferred for private key/mnemonic/ledger, delegate/undelegate, deposit/withdraw to save space
  • the Web wallet was rewritten, new rebranded screenshots, ROSE wallet renaming, contains ParaTime txes
  • the Browser extension chapter was made consistent with the web wallet
  • CSS: Indent the tabs content slightly and add left border now that the withdrawal/deposits, delegate/undelegate sections became pretty long
  • the Ledger chapter only contains Oasis nano app installation, refreshed with new Oasis nano app versions and Ledger Live screenshots, the majority was moved to a particular wallet implementation
  • the Custody Providers chapter was renamed to Custody Providers & Protocols and now also contains the Oasis Safe section
  • Oasis wallets/README was redundant, now it's auto-generated
  • The Telegram link was added to the footer
  • Add a few new glossary terms
  • Fixes two broken links in upgrade logs

The new structure is also ready for the mobile wallet once it's launched.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for oasisprotocol-docs ready!

Name Link
🔨 Latest commit c1c8f60
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-docs/deploys/663b8516571b0500086e2167
😎 Deploy Preview https://deploy-preview-777--oasisprotocol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matevz matevz force-pushed the matevz/docs/manage-tokens-revamp branch from 9b94a00 to e2bb41d Compare March 29, 2024 16:25
@matevz matevz force-pushed the matevz/docs/manage-tokens-revamp branch 3 times, most recently from e950837 to 3aefdc0 Compare April 4, 2024 12:18
@matevz matevz marked this pull request as ready for review April 4, 2024 12:18
@matevz matevz requested review from lukaw3d, lubej, CedarMist and kostko April 4, 2024 12:18
@matevz matevz force-pushed the matevz/docs/manage-tokens-revamp branch from 3aefdc0 to 9558584 Compare April 4, 2024 12:22
Copy link
Contributor

@aefhm aefhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly have nits and some questions. 👏 for working on this beast!

@matevz matevz force-pushed the matevz/docs/manage-tokens-revamp branch from 9558584 to 28a2911 Compare April 10, 2024 15:52
@matevz matevz requested review from aefhm, lukaw3d and kostko April 12, 2024 08:27
@matevz matevz force-pushed the matevz/docs/manage-tokens-revamp branch from 28a2911 to 466e18d Compare April 23, 2024 12:54
@matevz matevz requested a review from kostko April 23, 2024 12:55
@matevz matevz force-pushed the matevz/docs/manage-tokens-revamp branch 4 times, most recently from c59b311 to aedcf30 Compare April 24, 2024 08:50
@matevz matevz force-pushed the matevz/docs/manage-tokens-revamp branch from aedcf30 to af105ea Compare May 7, 2024 14:58
Copy link
Contributor

@aefhm aefhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking from me.

@matevz matevz requested a review from kostko May 7, 2024 16:26
@matevz matevz force-pushed the matevz/docs/manage-tokens-revamp branch 2 times, most recently from 31534a1 to 03c0a36 Compare May 8, 2024 13:24
@matevz matevz force-pushed the matevz/docs/manage-tokens-revamp branch from 2b6dd78 to c1c8f60 Compare May 8, 2024 13:58
@matevz matevz merged commit 83c9113 into main May 8, 2024
6 checks passed
@matevz matevz deleted the matevz/docs/manage-tokens-revamp branch May 8, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants