Skip to content

Architectural problems with the alpha secret #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EvanCarroll opened this issue Apr 27, 2025 · 0 comments
Open

Architectural problems with the alpha secret #302

EvanCarroll opened this issue Apr 27, 2025 · 0 comments

Comments

@EvanCarroll
Copy link

I think the -oauth2-proxy-alpha has a couple of questionable design decisions

I don't understand why we're storing the secret for alphaAuth as b64. Why not just store it as yaml? It makes sense when you're storing toml. But it doesn't make sense when the actual file is yaml. If it's valid yaml to begin with we don't have to worry about it not being valid yaml there.

I don't think we write out one file with all the secrets.. These should be mapped to environmental variables instead. Atleast the clientIds, and clientSecrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant