Add enum_no_longer_non_exhaustive lint.
#1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
reviewed
Mar 21, 2025
src/query.rs
Outdated
| @@ -1246,6 +1246,7 @@ add_lints!( | |||
| enum_tuple_variant_field_missing, | |||
| enum_tuple_variant_field_now_doc_hidden, | |||
| enum_unit_variant_changed_kind, | |||
| enum_unmarked_non_exhaustive, | |||
There was a problem hiding this comment.
Would you mind renaming this lint to follow the implicit convention for items that have stopped being ? For example, consider function_abi_no_longer_unwind.
| SemverQuery( | ||
| id: "enum_unmarked_non_exhaustive", | ||
| human_readable_name: "enum unmarked #[non_exhaustive]", | ||
| description: "A Public API enum is no longer #[non_exhaustive]", |
There was a problem hiding this comment.
Please ensure your capitalization and word/style choices match existing lints.
| "public": "public", | ||
| "non_exhaustive": "#[non_exhaustive]", | ||
| }, | ||
| error_message: "A Public API enum is no longer #[non_exhaustive]. External code may assume all variants are known, causing breaking changes if new ones are added.", |
There was a problem hiding this comment.
Same here: please pay close attention to capitalization and style and ensure everything matches existing lints. For example, we don't capitalize Public.
shreyans413
changed the title
enum_unmarked_non_exhaustive lint.enum_no_longer_non_exhaustive lint.
obi1kenobi
approved these changes
Mar 21, 2025
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following checkbox in #949 -
removing #[non_exhaustive] from a public API enum