Skip to content

Commit 429f321

Browse files
Dart 3.7: also run pub get in CI before formatting Flutter packages
1 parent 4eac0cd commit 429f321

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

.github/workflows/code-analysis.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,18 @@ permissions:
1515
env:
1616
# Do code analysis with latest SDK.
1717
# Pick a concrete version instead of "latest" to avoid builds breaking due to changes in new SDKs.
18+
FLUTTER_VERSION: 3.29.2 # Available versions: https://docs.flutter.dev/release/archive
1819
DART_VERSION: 3.7.2 # Available versions: https://dart.dev/get-dart/archive
1920

2021
jobs:
2122
analyze-and-format:
2223
runs-on: ubuntu-24.04
2324
steps:
2425
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
25-
# Prefer running on Ubuntu over Dart Docker image
26-
- uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672 # v1.6.5
26+
- uses: subosito/flutter-action@44ac965b96f18d999802d4b807e3256d5a3f9fa1 # v2.16.0
2727
with:
28-
sdk: ${{ env.DART_VERSION }}
28+
flutter-version: ${{ env.FLUTTER_VERSION }}
29+
cache: true
2930
- name: Get dependencies
3031
run: |
3132
dart pub get --directory=benchmark
@@ -45,7 +46,12 @@ jobs:
4546
dart analyze objectbox
4647
dart analyze objectbox_test
4748
- name: Check formatting of all packages
48-
run: dart format --set-exit-if-changed .
49+
# Since Dart 3.7, dart format needs pub get to run before formatting,
50+
# so to check formatting of Flutter packages run pub get for them first.
51+
run: |
52+
flutter pub get --directory=flutter_libs
53+
flutter pub get --directory=sync_flutter_libs
54+
dart format --set-exit-if-changed .
4955
5056
pana:
5157
runs-on: ubuntu-24.04

.gitlab-ci.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,14 @@ analyze-and-format:
5656
- dart analyze objectbox
5757
- dart analyze objectbox_test
5858
- dart analyze objectbox/example/dart-native/vectorsearch_cities
59-
# Check formatting of all packages
60-
- dart format --set-exit-if-changed .
59+
# Since Dart 3.7, dart format needs pub get to run before formatting,
60+
# so can no longer check formatting of Flutter packages (would require Flutter SDK):
61+
# Check formatting only for Dart packages
62+
- dart format --set-exit-if-changed benchmark
63+
- dart format --set-exit-if-changed generator
64+
- dart format --set-exit-if-changed objectbox
65+
- dart format --set-exit-if-changed objectbox_test
66+
- dart format --set-exit-if-changed objectbox/example/dart-native
6167

6268
# Runs generator integration tests, e.g. ensures generator works as expected.
6369
# Note: no need to test oldest SDK here, generator package is also built as part of unit-tests job.

0 commit comments

Comments
 (0)