Skip to content

Commit 22378f7

Browse files
committed
test.sh: go vet failures do not prevent tests from being executed
1 parent 574c694 commit 22378f7

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

build/test.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,17 @@ go_vet_result_lines=$(echo "$go_vet_result" | wc -l)
3232
if [ $go_vet_rc -ne 0 ]; then
3333
if [[ $go_vet_result_lines == 2 && $go_vet_result == *objectbox/c-callbacks.go*possible\ misuse\ of\ unsafe.Pointer* ]]; then
3434
echo "Ignoring known false positive of go vet"
35+
go_vet_rc=0
3536
else
3637
echo "go vet failed ($go_vet_rc)"
37-
exit $go_vet_rc
38+
# Fail later because we want to run tests for now too; was: exit $go_vet_rc
3839
fi
3940
fi
4041

4142
echo "******** Testing: go test ********"
4243
go test "$@" ./...
44+
45+
if [ $go_vet_rc -ne 0 ]; then
46+
echo "go vet failed ($go_vet_rc)"
47+
exit $go_vet_rc
48+
fi

0 commit comments

Comments
 (0)