document geo+centroid #1652
Merged
document geo+centroid #1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
requested changes
May 30, 2023
docs/marks/geo.md
Outdated
| @@ -128,6 +128,8 @@ Plot.plot({ | |||
| ``` | |||
| ::: | |||
|
|
|||
| The geo mark doesn’t have **x** and **y** channels; to derive those, for example to add [interactive tips](https://observablehq.com/@observablehq/plot-maps-tips), you can apply a [centroid transform](../transforms/centroid.md) on the geometries. | |||
There was a problem hiding this comment.
It would be nice to include an example of centroid + text for geo labels here, and to link to the tip mark documentation rather than the example notebook, since the tip mark documentation includes that example, plus a lot more information about “interactive tips”.
Alternatively maybe it would be better to replace that (somewhat odd!) “counties beginning with V” example in the centroid docs, and just label the states instead?
There was a problem hiding this comment.
Agreed; I additionally copied the (same) interactive tip example to the centroid page.
Fil
force-pushed
the
fil/document-geo-centroid
branch
from
6485f3e to
2a42af4
Compare
Fil
force-pushed
the
fil/document-geo-centroid
branch
from
52bdedd to
52e6b04
Compare
mbostock
reviewed
Jun 26, 2023
mbostock
reviewed
Jun 26, 2023
Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
approved these changes
Jun 26, 2023
Fil
added a commit
that referenced
this pull request
Aug 21, 2023
Co-authored-by: Mike Bostock <mbostock@gmail.com>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1651