-
Notifications
You must be signed in to change notification settings - Fork 185
Experiment: add support for distinguishing hover & click events #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yurivish
wants to merge
15
commits into
observablehq:main
Choose a base branch
from
yurivish:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b9e91cd
prototype support for distinguishing hover & click events via the Cus…
yurivish cd5988f
dispatch a subclass of Event with a sticky option
yurivish 3687112
move the StickyEvent definition inside the `plot` function
yurivish ca18ec3
fix formatting
yurivish 73a0e67
let's see what happens if we move the event back out to the top level…
yurivish 411a6ce
Revert "let's see what happens if we move the event back out to the t…
yurivish 9ce5bc4
store sticky state in a context field rather than on the figure element
yurivish 2ff8a1b
add an interactive test for sticky pointers which displays the clicke…
yurivish b53c9e8
rearrange comment
yurivish 57ed10e
manually generate desired output html for snapshot test
yurivish 91000aa
align output formatting with the pointerViewof test
yurivish 138b917
remove explicit initialization of context.stickyState
yurivish 615ff94
prettier
yurivish 02023a9
add generated snapshot test
yurivish 4e7b2dd
move sticky event to to the outside of the `plot` function
yurivish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.