doc: add instruction for rocks.nvim, warning for packer.nvim #14
Conversation
doc: remove some verbose description in plugin dependencies
| @@ -125,7 +125,8 @@ Client.set_workspace = function(self, workspace, opts) | |||
| self.callback_manager = CallbackManager.new(self, self.opts.callbacks) | |||
|
|
|||
| -- Setup UI add-ons. | |||
| if self.opts.ui.enable then | |||
| local has_no_renderer = not (util.get_plugin_info "render-markdown.nvim" or util.get_plugin_info "markview.nvim") | |||
| if has_no_renderer and self.opts.ui.enable then | |||
There was a problem hiding this comment.
Would this mean that even if a user tries to explicitly enable this plugin's ui, they wouldn't be able to do it if they have one of the other markdown rendering plugins? Maybe this could be the default behavior, but the user could enable it if they prefer. Or is there a reason to not allow them?
There was a problem hiding this comment.
because for now the two renderers are all automatically attaching to markdown buffers, and we have no way to shut them down when users want the builtin renderer. Thus causing conflict and bad user experience. People get very confused by this in the issue i mentioned. (me as well)
We could upstream stuff to the renderers like a buffer local varible to turn them off, but i think since our goal is to finally phase the builtin module out, it would make sense to just use the builtin as the last resort.
doc: remove some verbose description in plugin dependencies