Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Commands): Merge all commands into one :Obsidian command #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jblsp
Copy link

@jblsp jblsp commented Mar 16, 2025

This "namespaces" all of the commands as discussed here.

I accidentally closed the old PR, this is the one from before but with some changes to the command registering and it adds an option to enable all of the old commands.

@neo451
Copy link

neo451 commented Mar 18, 2025

thank you for your work, this looks amazing 👍
I have no issue merging this but looks like a big change that can break people's configs, the legacy commands approach is very nice indeed, I wonder @guspix @ffricken thinks
Plus, there's a few places in utils.lua and mappings.lua that uses the old command string, also the gf_passthrough in the README also need to change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants