Add support for class, class types and methods in DocumentSymbol #1487
Conversation
xvw
force-pushed
the
document-symbol-for-class-and-class-types
branch
from
109e180 to
e317de2
Compare
| ~kind:Class | ||
| ~range:(Range.of_loc decl.pci_loc) | ||
| ~selectionRange:(Range.of_loc decl.pci_name.loc) | ||
| ~children:(visit_class_sig decl.pci_expr) |
There was a problem hiding this comment.
Since you don't rely on the iterator for nested symbols like it's done in other cases, isn't there a risk that we would miss some of these nested symbols ?
Like x in class a = object method f = let x = 42 in x end ?
There was a problem hiding this comment.
I'm not sure you want to return that x, local value are usually not listed AFAICT (but don't take my word for it)
There was a problem hiding this comment.
That's a good question. From my (perhaps clumsy) point of view, I get the impression that we want to be able to navigate in all outlines, don't we?
There was a problem hiding this comment.
I tested it in vscode before writing my comment, and local values do show in the "outline",but maybe that's another request ?
xvw
changed the title
Pull Request Test Coverage Report for Build 4767Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4771Details
💛 - Coveralls |
xvw
changed the title
|
The PR is reviewable! |
|
Thanks Xavier, looks good to go. |
Should resolve #1449