Skip to content

Commit 9e214de

Browse files
kit-ty-katerjbou
andcommitted
Don't ask confirmation when pinning a new package
Co-authored-by: R. Boujbel <rjbou@ocamlpro.com>
1 parent d2f2e6b commit 9e214de

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

master_changes.md

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ users)
4747
## Pin
4848
* [NEW] Make it so pin list display the current revision of a pinned repository in a new column [#6274 @desumn - fix #5533]
4949
* [BUG] Stop double pin of packages located in ./opam/opam [#6343 @kit-ty-kate - fix #6342]
50+
* Don't ask confirmation when pinning an unknown package (absent from repositories) [#6309 @kit-ty-kate @rjbou - fix #3199]
5051

5152
## List
5253

src/client/opamPinCommand.ml

+4-6
Original file line numberDiff line numberDiff line change
@@ -491,12 +491,10 @@ and source_pin
491491
version, None
492492
in
493493

494-
if not (OpamPackage.has_name st.packages name) &&
495-
not (OpamConsole.confirm
496-
"Package %s does not exist, create as a %s package?"
497-
(OpamPackage.Name.to_string name)
498-
(OpamConsole.colorise `bold "NEW"))
499-
then raise Aborted;
494+
if not (OpamPackage.has_name st.packages name) then
495+
OpamConsole.note "Package %s does not exist in opam repositories \
496+
registered in the current switch."
497+
(OpamPackage.Name.to_string name);
500498

501499
(match OpamStd.Option.map OpamFile.URL.url cur_urlf, target_url with
502500
| Some u, Some target when OpamUrl.(

0 commit comments

Comments
 (0)