-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail when trying to pin a package whose definition could not be found instead of forcing interactive edition #6319
base: master
Are you sure you want to change the base?
Conversation
OpamConsole.note | ||
"No package definition found for %s: please complete the template" | ||
(OpamConsole.colorise `bold (OpamPackage.to_string nv)); | ||
OpamFileTools.template nv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really want to keep this template around? In which situation is it useful? I feel like it doesn't really has any purpose and we might want to remove it entirely (probably in a separate PR)
607c6cd
to
39b1927
Compare
39b1927
to
5e0a66d
Compare
Discussion on dev meeting: Overall agreement on blocked CI issue. We can't set the editing only on non tty as it is used hackishly in several places (our test for ex.) with specific command in OPAMEDITOR (cp/sed/etc.). |
…g opam description
47a607e
to
6a1afb5
Compare
… instead of forcing interactive edition
6a1afb5
to
ecf85c4
Compare
Fixes #6322
This could happen with things like
opam pin <typo> <url>
or a typo in thepin-depends
definition.The interactive edition based on the dummy opam file template is now only allowed if the user is purposefully requesting it using
--edit
oropam pin edit
.