Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression on 'opam upgrade <package>' upgrading unrelated things #6373

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

AltGr
Copy link
Member

@AltGr AltGr commented Jan 22, 2025

Regression introduced in 4db0c13, which is
dedicated to a different case (functionality of this patch is preserved)

@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Jan 23, 2025
@kit-ty-kate kit-ty-kate added KIND: BUG AREA: ENGINE PR: WIP Not for merge at this stage labels Jan 23, 2025
@kit-ty-kate kit-ty-kate force-pushed the noupgall branch 2 times, most recently from b578106 to b2030db Compare January 24, 2025 21:08
@kit-ty-kate kit-ty-kate removed the PR: WIP Not for merge at this stage label Jan 24, 2025
@kit-ty-kate kit-ty-kate requested a review from rjbou January 24, 2025 21:08
Comment on lines +440 to +489
=== upgrade 3 packages
- upgrade bar 2 to 3
- upgrade baz 1 to 2 [uses foo]
- upgrade foo 3 to 4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the origin of the regression ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same commit

Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by @AltGr too; lgtm!

@kit-ty-kate kit-ty-kate merged commit d0d22d8 into ocaml:master Feb 10, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants