Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: add a job that test plugins compilation #6394

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Feb 21, 2025

In it based on the same mechanism than opam-rt, it permits to keep them synchronised with the current API
TODO

  • add a release step to check CI log for failing projects
  • add a mechanism to retrieve automatically opam lib rev deps
  • add a mechanism to eliminate pinned packages that rely on old versions of opam

@rjbou rjbou requested a review from kit-ty-kate February 21, 2025 12:37
Comment on lines +197 to +200
test_project "ocaml-opam" "opam-publish" 0 "make"
test_project "AltGr" "opam-bundle" 0 "make"
test_project "ocamlpro" "opam-custom-install" 1 "dune build"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also suggest adding dune-release, odep, odig, odoc-driver, opam-check-npm-deps, opam-build, opam-test, opam-dune-lint, opam-graph, opam-package-upgrade, orb, opam-0install and topkg-care

Copy link
Collaborator Author

@rjbou rjbou Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was package to test (some are failing on purpose as they have a dependency on opam < 2.2, see commits message). We'll need to select what package to add here : they are blocking for the PR merge.
Ideally we would have another more light mechanism, one that sends the information as a comment in the PR for ex., like that we are aware without blocking the PR (for packages that we don't maintain).

@rjbou
Copy link
Collaborator Author

rjbou commented Feb 25, 2025

Discussion on dev meeting:
We don't want to enforce failling jobs on package that we don't maintain, but the information can be used to know which maintainer/project to ping. Ideally, it would be a job that opens an issue on the good repository, or adds a comment in the PR itself.
In the meanwhile, we would add 2 sets of dependencies to test:

  • the one that we maintain as opam team or as maintainer (opam-publish, opam-build, etc.) that would hard fail if there in an API breakage
  • the one that we don't maintain that would not make the job fail. It's up to us to go and look at the jobs, especially on releases
    It would also be nice to have an automatic selection of opam library rev deps from opam repo, but for that we need to add a step that eliminates package that are just incompatible (for ex ocaml-format < 2.3 soent' make sense to test).

main comment updated with TODOs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants