ocamldebug.el: Try and partially sync with camldebug.el (#227)
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tuareg.el (tuareg-font-lock-label-face): Remove odd `keep` element. * ocamldebug.el (ocamldebug-event): Use `:inverse-video`.
Align GPL version with that of `tuareg.el`. Use `macroexp-file-name` when available. Add `backstep` (C-k) and `display` (C-d) commands. (ocamldebug-track-frame): Mark it as a user option. (ocamldebug-mode-map): Comment out broken `M-?` binding. (ocamldebug-mode): Make sure \\[..] refs are resolved relative to the mode map rather than the current map. (def-ocamldebug): Prefer `when`. (ocamldebug-complete-filter): Use `push`. (ocamldebug-complete): Use `declare`. (ocamldebug): Rename arg to `file`, to match the docstring. Try and behave a bit better when `make-comint` returns another buffer than the one we expected. (ocamldebug-set-current-event): Remove `pos` argument. Use `before` instead (in the tty case) to decide whether to use `spos` or `epos`, like we already did in the GUI case. Also, set `overlay-arrow-position` in the current buffer only. (ocamldebug-display-line): Adjust caller accordingly.
monnier
force-pushed
the
scratch/sync
branch
from
9dcd371 to
92c7a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a binding to "backstep" by sync'ing with
camldebug.el.Align GPL version with that of
tuareg.el.Use
macroexp-file-namewhen available.Add
backstep(C-k) anddisplay(C-d) commands.(ocamldebug-track-frame): Mark it as a user option.
(ocamldebug-mode-map): Comment out broken
M-?binding.(ocamldebug-mode): Make sure \[..] refs are resolved relative to the mode map rather than the current map.
(def-ocamldebug): Prefer
when.(ocamldebug-complete-filter): Use
push.(ocamldebug-complete): Use
declare.(ocamldebug): Rename arg to
file, to match the docstring.Try and behave a bit better when
make-comintreturns another buffer than the one we expected.(ocamldebug-set-current-event): Remove
posargument.Use
beforeinstead (in the tty case) to decide whether to usesposorepos, like we already did in the GUI case. Also, setoverlay-arrow-positionin the current buffer only.(ocamldebug-display-line): Adjust caller accordingly.