Sync some fix from latest PyTelTools commits #52
Conversation
1a32c40: Fix mesh_origin to int + build_params a719ed1: Change params(8) header nb_el to 0
|
Hi @lucduron just change |
|
Hi @tomsail, I included your suggestion to fix the tests in this PR. All tests pass now. |
|
Sorry which PR should I look at now? |
|
Hi @tomsail, I pushed 2 additional commits on |
| @@ -120,7 +120,7 @@ class SerafinHeader: | |||
| - nb_nodes_per_elem <int>: number of nodes per element (= 3 in 2D and 6 in 3D) | |||
| - nb_nodes_2d <int>: number of 2D nodes (equals to `nb_nodes` in 2D) | |||
|
|
|||
| - mesh_origin <(float, float)>: x and y shift to apply to written coordinates (set by `set_mesh_origin`) | |||
| - mesh_origin <(int, int)>: x and y shift to apply to written coordinates (set by `set_mesh_origin`) | |||
| - x_stored <numpy.1D-array>: east written coordinates [shape = nb_nodes] | |||
There was a problem hiding this comment.
Can't we not specify decimal lat/lon coordinates ?
There was a problem hiding this comment.
mesh_origin is a tuple of 2 integers in PyTelTools, corresponding to x-coordinate and y-coordinate of the origin of the model.
It is excepted to be integers in the Selafin file format (IPARAM is a vector of 10 integers), see for example:
- Description of file full structure
- implementation of TelemacFile and SerafinFile
I do not know if a lat/long is possible, but it has to be an integer, due to the Selafin binary file format.
1a32c40: Fix mesh_origin to int + build_params
a719ed1: Change params(8) header nb_el to 0