Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of wasm_of_ocaml on binaryen-bin #1854

Closed

Conversation

OlivierNicole
Copy link
Contributor

Depending on an external tool as an opam package is non-standard and makes it harder to set up a CI (#1842), or when Binaryen is installed in some other way. I think we should just remove it.

@vouillon
Copy link
Member

vouillon commented Mar 5, 2025

If we want to remove this dependency, we need to provide a clear error message when the binaryen tools are not installed, or an old version is installed. People don't read the documentation...

In a CI, we can just do:

opam install --fake binaryen-bin

@vouillon
Copy link
Member

vouillon commented Mar 5, 2025

Also, making it harder to install wasm_of_ocaml may discourage people to try it.

@OlivierNicole
Copy link
Contributor Author

Is there a reason why we don't specify it as a depext?

@vouillon
Copy link
Member

vouillon commented Mar 5, 2025

Is there a reason why we don't specify it as a depext?

We could do that for some OSs / distributions, indeed, now that Binaryen 119 is not so recent anymore. But Ubuntu 24.10 still only provides version 108. And Github Actions are still using Ubuntu 24.04.

@hhugo
Copy link
Member

hhugo commented Mar 6, 2025

If we want to remove this dependency, we need to provide a clear error message when the binaryen tools are not installed, or an old version is installed. People don't read the documentation...

In a CI, we can just do:

opam install --fake binaryen-bin

@OlivierNicole, see https://github.com/OlivierNicole/js_of_ocaml/pull/3/files

@OlivierNicole
Copy link
Contributor Author

Thank you for your input, #1842 has been updated to rather use opam install --fake. Closing.

@OlivierNicole OlivierNicole deleted the remove-dep-binaryen branch March 6, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants