Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Obj.dup work on floats and boxed integers #1871

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Make Obj.dup work on floats and boxed integers #1871

merged 1 commit into from
Mar 12, 2025

Conversation

vouillon
Copy link
Member

No description provided.

@hhugo
Copy link
Member

hhugo commented Mar 12, 2025

Should we add a slice method to MlNat and Ml_Bigarray ?

@vouillon
Copy link
Member Author

Should we add a slice method to MlNat and Ml_Bigarray ?

It seems Obj.dup is not really supported for bigarrays in the native runtime (we get two bigarrays that share the same buffer, so the buffer gets freed when either is freed). nat is pretty much deprecated.

@hhugo hhugo merged commit 255e68d into master Mar 12, 2025
30 checks passed
@hhugo hhugo deleted the dup-numbers branch March 12, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhugo hhugo hhugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vouillon @hhugo