Improve Link_js performance #1875
Open
+173
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What improvement does that give in practice? |
|
See the first commit message. In addition, when building js_of_ocaml with itself in separate compilation mode, the final linking step falls down from ~550ms on master to ~120ms here. |
OlivierNicole
force-pushed
the
link-perf
branch
2 times, most recently
from
f4ee91d to
cf69bb8
Compare
This saves calls to `String.is_prefix` for the different kinds of "metadata" lines. @Enoumy measured on an internal project that it can save 20ms-40ms when linking, and up to ~120ms when `--pretty` is set.
Js_of_ocaml's linker used to read line-per-line each file twice. This patch is a performance optimization that changes the js_of_ocaml linker to read each file once, and also read the files "all at once". This speeds up linking, at the cost of extra peak memory utilization.
OlivierNicole
force-pushed
the
link-perf
branch
from
3524883 to
dac170e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pair of patches by @Enoumy, in use in the internal version of JSOO at Jane Street.