-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve async event retrieval workflow #647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Instead of writing `answer = Child.ask(...)`, write `answer, question_uuid = Child.ask(...)` (and the same for `ChildEmulator`)
This was
linked to
issues
Apr 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
==========================================
- Coverage 94.79% 94.62% -0.18%
==========================================
Files 82 82
Lines 3535 3552 +17
==========================================
+ Hits 3351 3361 +10
- Misses 184 191 +7 ☔ View full report in Codecov by Sentry. |
BREAKING CHANGE: To keep using the `get_events` function, add the `bigquery` optional extra to your installation command e.g. `poetry install -E bigquery`.
28df049
to
6d04c97
Compare
69bc7a3
to
b259028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents (#647)
IMPORTANT: There are 2 breaking changes.
Enhancements
Child.ask
get_event
get_events
Fixes
python3.11
dockerfileget_events
Operations
0.5.0
of event handler cloud function and update event store schemaactions/setup-python
to version 5Dependencies
db-dtypes
andgoogle-cloud-bigquery
optionalgunicorn
to avoid vulnerabilitynumpy
dependencyTesting
python3.10
(python3.9
isn't available onmacos-latest
forarm64
)Other
Upgrade instructions
💥 Return question UUID from `Child.ask`
Instead of writing
answer = Child.ask(...)
, writeanswer, question_uuid = Child.ask(...)
(and the same forChildEmulator
)💥 Make `db-dtypes` and `google-cloud-bigquery` optional
To keep using the
get_events
function, add thebigquery
optional extra to your installation command e.g.poetry install -E bigquery
.