Update child emulator and improve manifest dataset download #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 15, 2024
BREAKING CHANGE: Give events (including attributes) that satisfy the service communication schema to child emulators. skipci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
- Coverage 94.62% 94.55% -0.07%
==========================================
Files 82 83 +1
Lines 3552 3546 -6
==========================================
- Hits 3361 3353 -8
- Misses 191 193 +2 ☔ View full report in Codecov by Sentry. |
BREAKING CHANGE: load the JSON file separately and pass the events into the `ChildEmulator` constructor.
This was
linked to
issues
Jul 16, 2024
cortadocodes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents (#668)
IMPORTANT: There are 2 breaking changes.
Enhancements
ChildEmulatorto useEventReplayer, support schema-compliant events and attributes, and support heartbeats and delivery acknowledgement events. This significantly simplifies the emulatorChildEmulator.from_fileRefactoring
ServicePatcherinto its own moduleUpgrade instructions
💥 Update `ChildEmulator` to use `EventReplayer` and full events
Give events (including attributes) that satisfy the service communication schema to child emulators.
💥 Remove `ChildEmulator.from_file`
Load the JSON file separately and pass the events into the
ChildEmulatorconstructor.