Skip to content

Dependencies of this lib break TS on other apps #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GuillaumeHemmen opened this issue Jul 23, 2022 · 0 comments
Open

Dependencies of this lib break TS on other apps #34

GuillaumeHemmen opened this issue Jul 23, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@GuillaumeHemmen
Copy link
Contributor

GuillaumeHemmen commented Jul 23, 2022

Description:

When installing this library on a recent project, it install dependencies that cause typescript to goes banana. This is due to the following dependence tree:

  • react-native-logging-tools@^1.3.0
    • @types/enzyme-adapter-react-16" "^1.0.6"
      • @types/enzyme" "*"
        • @types/react" "*"

Due to this wildcard (*), type/react install the latest version available (18.0.15), which messes up with the current project under React 17. This SO thread was what made me dig up the yarn.lock.

This issue is not coming directly from this lib, but this lib uses @types/enzyme-adapter-react-16, which causes this issue.

Temporary workaround

Update your yarn.lock manually to change the version of "@types/react@*"

Steps To Reproduce

  1. create a new expo project (for example) and include this lib. The project must be in typescript!
  2. add a component like a button.
  3. see the error appear

Expected Results

No error should appear.

Snack, code example, screenshot, or link to a repository:

Personal project at a given time before I manually downgrade my yarn.lock (access must be granted)

@GuillaumeHemmen GuillaumeHemmen added the bug Something isn't working label Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants