[IMP] util.delete_unused

[KangOl]

Also consider child records when searching for record usage.

i.e. when try to remove a product category, also search for its sub categories as they will be cascade deleted if unused.

[robodoo]

[KangOl]

upgradeci retry with always only account account_reports appointment_account_payment auth_signup base calendar crm_iap_lead documents documents_hr event fleet hr_appraisal hr_expense hr_fleet hr_holidays hr_payroll hr_payroll_account hr_recruitment hr_timesheet industry_fsm industry_fsm_sale knowledge l10n_ae_hr_payroll l10n_ar l10n_at l10n_au_hr_payroll l10n_au_hr_payroll_account l10n_be l10n_be_hr_contract_salary l10n_be_hr_payroll l10n_ch_hr_payroll l10n_cl l10n_co l10n_de l10n_do l10n_es l10n_fr_hr_payroll l10n_hu l10n_in_hr_payroll l10n_it l10n_ke_hr_payroll l10n_lu_hr_payroll l10n_mn l10n_pe l10n_pl l10n_th l10n_tr mass_mailing payment payment_demo planning_contract point_of_sale portal_anonymous pos_pricer pos_restaurant product project project_todo repair resource sale_subscription sales_team sign stock stock_dropshipping survey training_base utm website_sale_slides website_slides in all versions

[aj-fuentes]

To be sure I understand:
We extend the delete_unused method to take into account children of the record being removed. In effect if a child has a cascade removal it is fine to consider the parent unused as long a the child is also unused.

I still have mixed feelings bout this because how can we be sure it is a parent/child relationship? Maybe it is a same-table relation but not really a parent/child situation. I'd feel more reassured if at least we restrict to parent_id columns :/

Just for the sake of ensuring we discuss it. If there is a parent/child relationship already present in the list of records to remove I think current approach is still correct.

This patch requires a small comment in the docs if we move forward.

[KangOl]

To be sure I understand: We extend the delete_unused method to take into account children of the record being removed. In effect if a child has a cascade removal it is fine to consider the parent unused as long a the child is also unused.

I still have mixed feelings bout this because how can we be sure it is a parent/child relationship? Maybe it is a same-table relation but not really a parent/child situation. I'd feel more reassured if at least we restrict to parent_id columns :/

The condition is same table + ondelete=cascade. I think it's enough to be considered to have a dependency between records.

Just for the sake of ensuring we discuss it. If there is a parent/child relationship already present in the list of records to remove I think current approach is still correct.

It bite us in the upgrade of odoo.com to saas~18.1 with the deletion of product categories.

This patch requires a small comment in the docs if we move forward.

Obviously

[aj-fuentes]

It bite us in the upgrade of odoo.com to saas~18.1 with the deletion of product categories.

I was actually referring to the approach in this patch :) In other words I wanted to be sure that the presence of parent-child relationship in the input will work well with the new implementation added in this patch (wrongly referred as "current approach")

[nseinlet]

@robodoo r+