passes exchangeCodeForTokens from idx.poll (#1585)

OKTA-912523 fix: passes exchangeCodeForTokens from idx.poll

Author: jaredperreault-okta

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+# 7.12.1
+
+### Fixes
+
+- [#1585](https://github.com/okta/okta-auth-js/pull/1585) fix: `idx.poll` now respects `exchangeCodeForTokens` and `withCredentials` options
+
 # 7.12.0
 
 ### Features

lib/idx/poll.ts

@@ -21,8 +21,11 @@ import { getSavedTransactionMeta } from './transactionMeta';
 import { warn } from '../util';
 
 export async function poll(authClient: OktaAuthIdxInterface, options: IdxPollOptions = {}): Promise<IdxTransaction> {
+  const { withCredentials, exchangeCodeForTokens } = options;
   let transaction = await proceed(authClient, {
-    startPolling: true
+    startPolling: true,
+    withCredentials,
+    exchangeCodeForTokens
   });
 
   const meta = getSavedTransactionMeta(authClient);

lib/idx/types/api.ts

@@ -36,6 +36,7 @@ import {
   ActivationData,
 } from './idx-js';
 import {
+  IdxOptions,
   AccountUnlockOptions,
   AuthenticationOptions,
   CancelOptions,
@@ -91,7 +92,7 @@ export type Input = {
 }
 
 
-export interface IdxPollOptions {
+export interface IdxPollOptions extends Pick<IdxOptions, 'exchangeCodeForTokens' | 'withCredentials' > {
   required?: boolean;
   refresh?: number;
 }

package.json

@@ -2,7 +2,7 @@
   "private": true,
   "name": "@okta/okta-auth-js",
   "description": "The Okta Auth SDK",
-  "version": "7.12.0",
+  "version": "7.12.1",
   "homepage": "https://github.com/okta/okta-auth-js",
   "license": "Apache-2.0",
   "main": "build/cjs/exports/default.js",

test/spec/idx/poll.ts

@@ -159,6 +159,33 @@ describe('idx/poll', () => {
     expect(mocked.proceed.proceed).toHaveBeenCalledTimes(1);
   });
 
+  it('passes RunOptions through to `procced`', async () => {
+    const {
+      authClient,
+      enrollPollResponse
+    } = testContext;
+
+    chainResponses([
+      enrollPollResponse,
+      enrollPollResponse,
+    ]);
+
+    jest.spyOn(mocked.introspect, 'introspect')
+      .mockResolvedValue(enrollPollResponse);
+    const proccedSpy = jest.spyOn(mocked.proceed, 'proceed');
+
+    await poll(authClient, {
+      exchangeCodeForTokens: false,
+      withCredentials: false
+    });
+    expect(proccedSpy).toHaveBeenCalledTimes(1);
+    expect(proccedSpy).toHaveBeenLastCalledWith(authClient, expect.objectContaining({
+      startPolling: true,
+      exchangeCodeForTokens: false,
+      withCredentials: false
+    }));
+  });
+
   it('polls until completion when refresh parameter is passed', async () => {
     const {
       authClient,