Added help, changelog and HasIndependentRelease validation

CHANGELOG.md

@@ -1,3 +1,4 @@
+- Added capability of playing release of percussive pipes with Pipe999HasIndependentRelease=Y https://github.com/GrandOrgue/grandorgue/issues/1385
 - Added capability of loading only GUI panels without audio samples by specifying the "-g" switch from the command line https://github.com/GrandOrgue/grandorgue/issues/1602
 - Removed support of MacOS 11 https://github.com/GrandOrgue/grandorgue/issues/1791
 - Fixed crash on loading an organ with a crescendo in Add mode https://github.com/GrandOrgue/grandorgue/issues/1772

help/grandorgue.xml

@@ -9909,9 +9909,22 @@ on which the pipes of the are placed.
           <term>Percussive</term>
           <listitem>
             <para>
-(boolean, required) If false, the samples are played as is (without
-any loop/release handling)
-     </para>
+	      (boolean, required) If false, the samples are played as is
+	      (without any loop/release handling).
+	    </para>
+          </listitem>
+        </varlistentry>
+        <varlistentry>
+          <term>HasIndependentRelease</term>
+          <listitem>
+            <para>
+	      (boolean, default false or inherited from the Organ, Windchest or
+	      Rank). If true than release is played independently on the attack.
+	    </para>
+            <para>
+	      If HasIndependentRelease is true then Percussive must also be set
+	      to true.
+	    </para>
           </listitem>
         </varlistentry>
         <varlistentry>
@@ -9950,6 +9963,17 @@ The attributes of each pipe are prefixed with
 attributes are:
       </para>
       <variablelist>
+        <varlistentry>
+          <term>Pipe999</term>
+          <listitem>
+            <para>
+(string, required) Relative path to the sample WAV file of the first
+attack. It may be listed as REF:aa:bb:cc too. In that case, it means
+that this pipe is borrowed from manual aa, first rank of stop bb, the pipe cc.
+It may contain DUMMY, which defines a non-sounding placeholder.
+     </para>
+          </listitem>
+        </varlistentry>
         <varlistentry>
           <term>Pipe999Percussive</term>
           <listitem>
@@ -9959,6 +9983,19 @@ played as is (without any loop/release handling)
      </para>
           </listitem>
         </varlistentry>
+        <varlistentry>
+          <term>Pipe999HasIndependentRelease</term>
+          <listitem>
+            <para>
+	      (boolean, default: rank HasIndependentRelease setting). If true
+	      then the release is played independently on the attack.
+	    </para>
+            <para>
+	      If HasIndependentRelease is true then Pipe999Percussive must be
+	      also true and Pipe999ReleaseCount must be greater than 0.
+	    </para>
+          </listitem>
+        </varlistentry>
         <varlistentry>
           <term>Pipe999AmplitudeLevel</term>
           <listitem>
@@ -9992,17 +10029,6 @@ number of cents (in addition to the organ/rank factor).
             <para>
 (integer 0 - 10000, default: 0) Delay introduced by the tracker for
 that pipe.
-     </para>
-          </listitem>
-        </varlistentry>
-        <varlistentry>
-          <term>Pipe999</term>
-          <listitem>
-            <para>
-(string, required) Relative path to the sample WAV file of the first
-attack. It may be listed as REF:aa:bb:cc too. In that case, it means
-that this pipe is borrowed from manual aa, first rank of stop bb, the pipe cc.
-It may contain DUMMY, which defines a non-sounding placeholder.
      </para>
           </listitem>
         </varlistentry>

src/grandorgue/model/GOSoundingPipe.cpp

@@ -266,6 +266,14 @@ void GOSoundingPipe::Load(
 
   unsigned release_count = cfg.ReadInteger(
     ODFSetting, group, prefix + wxT("ReleaseCount"), 0, 100, false, 0);
+
+  if (m_PipeConfigNode.IsEffectiveIndependentRelease() && !release_count)
+    wxLogWarning(
+      _("The pipe %s/%s has independent release but %sReleaseCount=0"),
+      group,
+      prefix,
+      prefix);
+
   for (unsigned i = 1; i <= release_count; i++)
     LoadReleaseFileInfo(
       cfg, group, wxString::Format(wxT("%sRelease%03d"), prefix, i));