Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #8 #19

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Issue #8 #19

merged 4 commits into from
Oct 2, 2024

Conversation

Prathmesh-rajurkar
Copy link
Contributor

Your issue #8 , is been solved in this commit

Your issue ombhojane#8  , is been solved in this commit
@ombhojane
Copy link
Owner

image

I'm facing this issue while running, are facing the same?

I tried to fix as:
def generate_report(self, section: List, filename='xai_report.pdf'):

but gave following error -
An error occurred while generating the report: XAIWrapper.generate_report() missing 1 required positional argument: 'section'

Resolved the bug of non functional argument and funtional arguments
@Prathmesh-rajurkar
Copy link
Contributor Author

Pls Check Now @ombhojane

@ombhojane
Copy link
Owner

Hey, it's not giving any errors now.

it supposed to be asked as:
allow all section to be exported in xai_report: Yes/No

If I tapped No:
then it'll give available sections one by one and I'll tap Yes/No

This allows user credibility to choose what data would be saved in report

@Prathmesh-rajurkar
Copy link
Contributor Author

Okay , I will be making some chnages , pls look after it
Is it okay if I could (y/n) options in terminal ???

Made Changes in generate_report , it ask for permission before adding any section report into "xia_report"
@Prathmesh-rajurkar
Copy link
Contributor Author

Made changes according to your wish pls check @ombhojane

@ombhojane
Copy link
Owner

Thanks @Prathmesh-rajurkar for contribution!

@ombhojane ombhojane merged commit 4fad1fd into ombhojane:main Oct 2, 2024
1 of 4 checks passed
@ombhojane
Copy link
Owner

#8 has been resolved

@Prathmesh-rajurkar
Copy link
Contributor Author

Prathmesh-rajurkar commented Oct 2, 2024

{1E6E83B7-F2CF-431B-8233-C1876420CBF1}

Thank You So Much @ombhojane for the opportunity
Can you help me out in this
It will be very helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants